Skip to content
This repository was archived by the owner on Dec 12, 2023. It is now read-only.

check_v46 remove leading spaces from perf data#84

Open
paulboot wants to merge 1 commit into
bzed:masterfrom
paulboot:master
Open

check_v46 remove leading spaces from perf data#84
paulboot wants to merge 1 commit into
bzed:masterfrom
paulboot:master

Conversation

@paulboot

@paulboot paulboot commented Oct 5, 2018 •
edited
Loading

Copy link
Copy Markdown

Some plugins, like check_ssh, add a leading space to the perf data and check_v46 should remove this space or the prepended ipv4_a1_ and ipv6_a1_ will have a trailing space because service-perfdata scripts will fail to parse the performance data.

Example output with trailing space:

$ /usr/lib/naemon/plugins/check_v46 --debug-wrapper -a 192.168.3.1 -A 2001:470:1f15:a46::1 /usr/lib/naemon/plugins/check_ssh -P 2.0 -p 22987
debug: Running '/usr/lib/naemon/plugins/check_ssh -6 -P 2.0 -p 22987 --hostname 2001:470:1f15:a46::1
debug: Plugin output 1st line: 'SSH OK - OpenSSH_6.6.1p1 Debian-4~bpo70+1 (protocol 2.0) | time=0.088580s;;;0.000000;10.000000'
debug: Reformatted performance data: 'ipv6_a1_ time=0.088580s;;;0.000000;10.000000'
debug: Plugin result: 0 (OK)
debug: Running '/usr/lib/naemon/plugins/check_ssh -4 -P 2.0 -p 22987 --hostname 192.168.3.1
debug: Plugin output 1st line: 'SSH OK - OpenSSH_6.6.1p1 Debian-4~bpo70+1 (protocol 2.0) | time=0.090877s;;;0.000000;10.000000'
debug: Reformatted performance data: 'ipv4_a1_ time=0.090877s;;;0.000000;10.000000'
debug: Plugin result: 0 (OK)
OK: IPv6/2001:470:1f15:a46::1 OK, IPv4/192.168.3.1 OK | ipv6_a1_ time=0.088580s;;;0.000000;10.000000 ipv4_a1_ time=0.090877s;;;0.000000;10.000000
                                                        ^^^^^^^^^^^^^^
Status details:
IPv6/2001:470:1f15:a46::1:
SSH OK - OpenSSH_6.6.1p1 Debian-4~bpo70+1 (protocol 2.0)
IPv4/192.168.3.1:
SSH OK - OpenSSH_6.6.1p1 Debian-4~bpo70+1 (protocol 2.0)

@paulboot
Remove leading spaces from perf data
b615a86 
Some plugins, like check_ssh, add a leading space to the perf data and check_v46 should remove these space or the prepended ipv4_a1_ and ipv6_a1_ will have a trailing space.
@paulboot paulboot changed the title Remove leading spaces from perf data check_v46 remove leading spaces from perf data Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@paulboot